Conversation
POSIX still backslash-escapes spaces. cmd.exe does not treat a backslash-space as an escaped space, so quote the path instead. Fixes pyinvoke#1001.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context.cdprefixesrun/sudowithcd <path> &&. Spaces in the path were always turned into POSIXfoo\ bar. That is valid for bash, butcmd.exetreats the backslash as a path separator, so Windows fails with "The system cannot find the path specified."On Windows, leave the space in
cwdand quote thecdargument instead. POSIX still backslash-escapes. Paths without spaces are unchanged on both platforms.Tests:
pytest tests/context.py(new cases patchWINDOWSso they run on POSIX CI too).Fixes #1001