Skip to content

Preserve target authorities in definition and reference URIs - #725

Open
jakezwang wants to merge 1 commit into
python-lsp:developfrom
jakezwang:fix/target-location-uris
Open

jakezwang wants to merge 1 commit into
python-lsp:developfrom
jakezwang:fix/target-location-uris

Conversation

@jakezwang

Copy link
Copy Markdown

Definition and reference locations inherit the source document’s URI authority. A target on another UNC server gets the wrong server, while a target on a local drive retains the original UNC authority.

Build each target URI from Jedi’s filesystem path. Add regression tests for local-to-UNC, cross-server, UNC-to-local and same-share locations in both plugins.

Validation: full suites on Python 3.12 and 3.14 (209 passed, 10 skipped each), Ruff, configuration schema/generation and package checks. Python 3.9 has two autoimport failures that also reproduce with the original code in the same checkout. Windows path conversion is tested on macOS with PureWindowsPath and the Windows URI conversion branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant