Repository navigation
Fix the marker shape for hex Icon colors - #2300
Merged
hansthen merged 1 commit intoOct 17, 2026
Merged
Conversation
Leaflet positions the marker with an inline transform, which replaced the rotation in the generated CSS and left a lopsided shape with a tilted glyph. Draw the pin on a pseudo-element instead, sized like the sprite markers. Also warn again for a non-string color instead of raising AttributeError.
Collaborator
|
Looks good to me. Do not worry about the failing docs publishing test. This will be fixed when we issue a new release. @xecanto Do you want me to merge this? |
Contributor
Author
|
Yes please, thanks! |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2293
Hex colors (#2211) render as a lopsided blob because Leaflet's inline
transformoverrides the CSS rotation. The pin is now drawn on a::beforesized like the sprite markers. This also restores the warning for a non-stringcolor, which raisedAttributeError.