Skip to content

chore: use cryptography package instead of openssl.crypto in tests - #823

Merged
StephenSorriaux merged 1 commit into
python-zk:masterfrom
ThosRTanner:issue/782/use-diff-crypto-library
Oct 4, 2026
Merged

StephenSorriaux merged 1 commit into
python-zk:masterfrom
ThosRTanner:issue/782/use-diff-crypto-library

Conversation

@ThosRTanner

Copy link
Copy Markdown
Contributor

Fixes #782

Why is this needed?

Stops us moving to later versions of openssl module

Proposed Changes

  • Rip out all of openssl.crypto logic in testing/common.py and replace with cryptography calls

Does this PR introduce any breaking change?

No - this only affects testing

@ThosRTanner
ThosRTanner force-pushed the issue/782/use-diff-crypto-library branch from b3a64ba to 7f2db60 Compare September 18, 2026 17:09
@codecov

codecov Bot commented Sep 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.90%. Comparing base (f54c4fd) to head (46c3f93).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #823   +/-   ##
=======================================
  Coverage   94.90%   94.90%           
=======================================
  Files          27       27           
  Lines        3811     3811           
=======================================
  Hits         3617     3617           
  Misses        194      194           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ThosRTanner
ThosRTanner force-pushed the issue/782/use-diff-crypto-library branch from 7f2db60 to cd36344 Compare September 19, 2026 16:12
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Sep 19, 2026
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Sep 19, 2026
Comment thread pyproject.toml Outdated
"cryptography==50.0.1",
"objgraph==3.6.2",
"pyOpenSSL<26.2.0",
"pyOpenSSL==26.4.0",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still need pyOpenSSL now?

@ThosRTanner ThosRTanner Sep 26, 2026 •

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm. i thought we did but I shall check
...
short while later
kicks self.

Removed it...

Comment thread kazoo/testing/common.py
@ThosRTanner
ThosRTanner force-pushed the issue/782/use-diff-crypto-library branch from cd36344 to 3a0ecc0 Compare September 26, 2026 21:12
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Sep 26, 2026
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Sep 26, 2026
@ThosRTanner
ThosRTanner force-pushed the issue/782/use-diff-crypto-library branch from 3a0ecc0 to 46c3f93 Compare October 2, 2026 16:39

@StephenSorriaux StephenSorriaux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@StephenSorriaux
StephenSorriaux merged commit f6a78f7 into python-zk:master Oct 4, 2026
33 checks passed
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Oct 8, 2026
@ThosRTanner
ThosRTanner deleted the issue/782/use-diff-crypto-library branch October 8, 2026 20:10
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Oct 9, 2026
ThosRTanner added a commit to ThosRTanner/kazoo that referenced this pull request Oct 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pyopenssl crypto is deprecated - should move to a new cryptography package (tests fail badly...)

2 participants