Skip to content

gh-156722: Terminate tracing processes gracefully on timeout for test_dtrace - #156753

Merged
vstinner merged 2 commits into
python:mainfrom
stratakis:sigterm_dtrace
Sep 23, 2026
Merged

gh-156722: Terminate tracing processes gracefully on timeout for test_dtrace#156753
vstinner merged 2 commits into
python:mainfrom
stratakis:sigterm_dtrace

Conversation

@stratakis

@stratakis stratakis commented Sep 1, 2026 •
edited by aisk
Loading

Copy link
Copy Markdown
Contributor

Send SIGTERM to the tracing process group before falling back to SIGKILL.

@stratakis
pythongh-156722: Terminate tracing processes gracefully on timeout fo…
fbd9755 
…r test_dtrace

Send SIGTERM to the tracing process group before falling back to SIGKILL.
@bedevere-app bedevere-app Bot added tests Tests in the Lib/test dir awaiting review labels Sep 1, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Sep 1, 2026
Open
@stratakis

stratakis commented Sep 1, 2026

Copy link
Copy Markdown
Contributor Author

cc @vstinner

@aisk aisk added the skip news label Sep 1, 2026
@aisk aisk changed the title gh-156722: Terminate tracing processes gracefully on timeout for test… gh-156722: Terminate tracing processes gracefully on timeout for test_dtrace Sep 1, 2026
vstinner
vstinner reviewed Sep 21, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with the idea of sending SIGTERM first, and only call SIGKILL after a timeout. I have a few comments on the actual implementation.

I failed to reproduce #156701 by running test_dtrace manually. I tested on two buildbots (CentOS 10 x86-64 and CentOS 9 ppc64le).

Comment thread Lib/test/test_dtrace.py Outdated
Comment thread Lib/test/test_dtrace.py Outdated
@vstinner
vstinner merged commit 55ecc0a into python:main Sep 23, 2026
49 checks passed
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Sep 23, 2026
@miss-islington-app

miss-islington-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

Thanks @stratakis for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

Sorry, @stratakis and @vstinner, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 55ecc0a40918ba0346bc83ef639b655b8a883645 3.13

@miss-islington-app

miss-islington-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

Sorry, @stratakis and @vstinner, I could not cleanly backport this to 3.14 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 55ecc0a40918ba0346bc83ef639b655b8a883645 3.14

@bedevere-app

bedevere-app Bot commented Sep 23, 2026

Copy link
Copy Markdown

GH-157985 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Sep 23, 2026
hugovk pushed a commit that referenced this pull request Sep 28, 2026
@miss-islington @stratakis
[3.15] gh-156722, test_dtrace: Terminate tracing processes gracefully…
db379c4 
… on timeout (GH-156753) (#157985)

Co-authored-by: stratakis <stratakishar@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments

Assignees

@vstinner vstinner

Labels

needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stratakis @vstinner @aisk