gh-156865: struct.pack() check for overflows for Zf type - #156868
Open
skirpichev wants to merge 5 commits into
Open
skirpichev wants to merge 5 commits into
skirpichev wants to merge 5 commits into
Conversation
skirpichev
added
needs backport to 3.14
skirpichev
changed the title
skirpichev
removed
needs backport to 3.14
vstinner
reviewed
Sep 18, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
vstinner
reviewed
Sep 23, 2026
Comment on lines
+436
to
+441
| ba = bytearray(8) | ||
| try: | ||
| struct.Struct(format).pack_into(ba, 0, value) | ||
| assert False | ||
| except OverflowError: | ||
| self.assertEqual(ba, bytearray(8)) |
Member
There was a problem hiding this comment.
I recommend using assertRaises(). "assert False" is removed if Python is run with -O option.
Suggested change
| ba = bytearray(8) | |
| try: | |
| struct.Struct(format).pack_into(ba, 0, value) | |
| assert False | |
| except OverflowError: | |
| self.assertEqual(ba, bytearray(8)) | |
| ba = bytearray(8) | |
| with self.assertRaises(OverflowError): | |
| struct.Struct(format).pack_into(ba, 0, value) | |
| self.assertEqual(ba, bytearray(8)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.