Skip to content

gh-157199: Add fast inline _PyMapping_Check to pycore_abstract.h #157200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
denizguney wants to merge 1 commit into from
+9 −1
Closed

gh-157199: Add fast inline _PyMapping_Check to pycore_abstract.h #157200

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion Include/internal/pycore_abstract.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,14 @@ _PyIndex_Check(PyObject *obj)
return (tp_as_number != NULL && tp_as_number->nb_index != NULL);
}

// Fast inlined version of mapping check (Optimized for internal core protocols)
static inline int
_PyMapping_Check(PyObject *obj)
Comment on lines +19 to +21

@skirpichev skirpichev Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It unused. Hence, addition is useless.

{
PyMappingMethods *tp_as_mapping = Py_TYPE(obj)->tp_as_mapping;
return (tp_as_mapping != NULL && tp_as_mapping->mp_subscript != NULL);
}

// Exported for external JIT support
PyAPI_FUNC(PyObject *) _PyNumber_PowerNoMod(PyObject *lhs, PyObject *rhs);
PyAPI_FUNC(PyObject *) _PyNumber_InPlacePowerNoMod(PyObject *lhs, PyObject *rhs);
Expand All @@ -40,7 +48,7 @@ PyAPI_FUNC(int) _PyObject_HasLen(PyObject *o);
PY_ITERSEARCH_CONTAINS: return 1 if obj in seq, else 0; -1 on
error. */
extern Py_ssize_t _PySequence_IterSearch(PyObject *seq,
PyObject *obj, int operation);
PyObject *obj, int operation);

@skirpichev skirpichev Sep 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated change.


/* === Mapping protocol ================================================= */

Expand Down
Loading