gh-108668: Preserve exception state during delegated throw - #157235
Open
joaogabriel15 wants to merge 1 commit into
Open
gh-108668: Preserve exception state during delegated throw#157235joaogabriel15 wants to merge 1 commit into
joaogabriel15 wants to merge 1 commit into
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #108668.
When throw() is forwarded through yield from or await, the delegating generator is linked into the frame stack but its handled-exception state is not linked into tstate->exc_info. The delegated code can consequently inherit the caller's exception instead of the delegating generator's exception.
Link and restore gi_exc_state around both native generator/coroutine delegation and calls to a custom iterator's throw method.
Regression tests cover native generators, a custom iterator wrapper, nested await, and restoration of the caller's handled exception. All three regression scenarios fail on the original Windows debug build and pass with the change.
Validation: Windows x64 debug build; test_yield_from, test_generators, test_coroutines, test_asyncgen, test_genexps, test_exceptions, test_contextlib, and test_asyncio. Result: SUCCESS, 3,163 tests run, 92 skipped; 41 test files passed and the Unix-only file was skipped.
exc_infocan get lost whenthrowing into anawaitoryield from#108668