gh-157216: Document that forkserver preload skips deferred imports - #157237
Open
mohsen-rahmati-dev wants to merge 1 commit into
Open
gh-157216: Document that forkserver preload skips deferred imports#157237mohsen-rahmati-dev wants to merge 1 commit into
mohsen-rahmati-dev wants to merge 1 commit into
Conversation
Documentation build overview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current
set_forkserver_preload()entry says the named modules' "already imported state is inherited by forked processes", but doesn't say what happens to a module that a preloaded module imports inside a function body rather than at module level. Those are not imported in the forkserver process, so each child imports them privately on first use.This adds a paragraph after the opening description: module-level imports are inherited (transitively), imports inside function bodies are not, with
datetime.strptime()/_strptimeas the example, and a note that calling such a function at the module level of a preloaded module puts the import in the forkserver.Measurements, module counts and a reproducer are in gh-157216.
Docs-only, so no
Misc/NEWS.dentry.