gh-140971: Document pathlib.PurePath("") meaning and bool value - #157293
Open
terryjreedy wants to merge 3 commits into
Open
terryjreedy wants to merge 3 commits into
terryjreedy wants to merge 3 commits into
Conversation
pathlib.PurePath() and pathlib.PurePath('') both mean the
current working directory and both have boolean value True.
Patch implements suggestion in
python#140993 (comment).
---
Co-authored-by: LiuQhahah <liuqiang9596@gmail.com>
Member
Author
|
@StanFromIreland Please check that co-author note is correct. Add to commit message if too terse. |
Documentation build overview
62 files changed ·
|
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay, this slipped my mind.
| (PurePosixPath('.'), PurePosixPath('.')) | ||
|
|
||
| The boolean value of either expression is True. | ||
| This differs from ``os.path.exists("")``, which returns ``False``. |
Member
There was a problem hiding this comment.
Suggested change
| This differs from ``os.path.exists("")``, which returns ``False``. | |
| Because ``Path('')`` refers to the current directory, ``Path('').exists()`` | |
| returns ``True``, unlike :func:`os.path.exists`, which returns ``False`` | |
| for an empty string. |
Actually, I think this would be better placed in the .exists() documentation?
Member
Author
There was a problem hiding this comment.
I added a shorter sentence to the 'exists' entry. Please review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pathlib.PurePath() and pathlib.PurePath('') both mean the current working directory and both have boolean value True.
Patch implements suggestion in
#140993 (comment).
Co-authored-by: LiuQhahah liuqiang9596@gmail.com