Skip to content

[3.15] gh-155526: Don't check errno in abs(complex) (GH-155527) - #157341

Merged
hugovk merged 1 commit into
python:3.15from
skirpichev:backport-e5d4fa2-3.15
Sep 15, 2026
Merged

[3.15] gh-155526: Don't check errno in abs(complex) (GH-155527)#157341
hugovk merged 1 commit into
python:3.15from
skirpichev:backport-e5d4fa2-3.15

Conversation

@skirpichev

@skirpichev skirpichev commented Sep 11, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

abs(complex) no longer raises OverflowError if errno was set to ERANGE by some library call but abs() doesn't overflow.

(cherry picked from commit e5d4fa2)

@skirpichev @vstinner @hpkfft
[3.15] pythongh-155526: Don't check errno in abs(complex) (pythonGH-1…
05c31b1 
…55527)

abs(complex) no longer raises OverflowError if errno was set to ERANGE
by some library call but abs() doesn't overflow.

(cherry picked from commit e5d4fa2)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: hpkfft.com <paul@hpkfft.com>
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2026
Closed
@bedevere-app bedevere-app Bot mentioned this pull request Sep 11, 2026
Merged
@skirpichev
skirpichev requested a review from vstinner September 11, 2026 23:55
@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Sep 11, 2026
vstinner
vstinner approved these changes Sep 13, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hugovk
hugovk merged commit 340cfba into python:3.15 Sep 15, 2026
64 checks passed
@miss-islington-app

miss-islington-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Thanks @skirpichev for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

Sorry, @skirpichev and @hugovk, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 340cfbaf679c1230fd438042d764b6922b483242 3.13

@bedevere-app

bedevere-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

GH-157555 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Sep 15, 2026
@bedevere-app

bedevere-app Bot commented Sep 15, 2026

Copy link
Copy Markdown

GH-157558 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.13 bugs and security fixes label Sep 15, 2026
hugovk pushed a commit that referenced this pull request Sep 15, 2026
@miss-islington @skirpichev
@vstinner @hpkfft
[3.14] gh-155526: Don't check errno in abs(complex) (GH-155527) (GH-1…
2818087 
…57341) (#157555)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: Victor Stinner <vstinner@python.org>
Co-authored-by: hpkfft.com <paul@hpkfft.com>
@skirpichev
skirpichev deleted the backport-e5d4fa2-3.15 branch September 15, 2026 19:34
vstinner added a commit that referenced this pull request Sep 23, 2026
@vstinner @skirpichev @hpkfft
[3.13] gh-155526: Don't check errno in abs(complex) (GH-155527) (#157341
bb8572f 
) (#157558)

[3.15] gh-155526: Don't check errno in abs(complex) (GH-155527) (#157341)



(cherry picked from commit 340cfba)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
Co-authored-by: hpkfft.com <paul@hpkfft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

@hugovk hugovk

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @vstinner @hugovk