Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Lib/mailbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -1495,6 +1495,7 @@ def _install_message(self, message):
vis_buffer = io.BytesIO()
vis_generator = email.generator.BytesGenerator(vis_buffer, False, 0)
vis_generator.flatten(message.get_visible())
vis_buffer.seek(0)
while True:
line = vis_buffer.readline()
self._file.write(line.replace(b'\n', linesep))
Expand Down
13 changes: 13 additions & 0 deletions Lib/test/test_mailbox.py
Original file line number Diff line number Diff line change
Expand Up @@ -1521,6 +1521,19 @@ def test_labels(self):
self._box.remove(key1)
self.assertEqual(set(self._box.get_labels()), set(['blah']))

def test_visible(self):
# gh-157880: visible headers are written to the file and read back
msg = mailbox.BabylMessage(self._template % 0)
msg.update_visible()
key = self._box.add(msg)
for retrieved in (self._box.get_message(key), self._box[key]):
self.assertEqual(retrieved['from'], 'foo')
self.assertEqual(retrieved.get_payload(), '0\n')
self.assertEqual(retrieved.get_visible().keys(), ['From'])
self.assertEqual(retrieved.get_visible()['from'], 'foo')
self.assertEqual(self._box.get_bytes(key),
(self._template % 0).encode('ascii'))


class FakeFileLikeObject:

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Fix :class:`mailbox.Babyl` to write the visible headers of a
:class:`mailbox.BabylMessage` to the mailbox file.
Loading