You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is the first step towards splitting the Android testbed into a separate repository. For this PR, all code still remains in the cpython repository, but we create a "lower-level script" as described in the linked issue, which can be used to run Android apps other than the Python testbed.
For example, you can use the script to run one of the test apps from chaquo/chaquopy#1474:
msmith@MacBook-Pro cpython % python Platforms/Android/android_run.py --connected emulator-5554 -P chaquopy.version=3.13 -P chaquopy.packages="brotli murmurhash" ~/git/chaquo/chaquopy/server/pypi/pkgtest
Waiting for app to start - this may take several minutes
PID: 32448
test_basic (chaquopy.test.brotli.TestBrotli.test_basic) ... ok
test_basic (chaquopy.test.murmurhash.TestMurmurhash.test_basic) ... ok
----------------------------------------------------------------------
Ran 2 tests in 0.006s
OK
My initial impression is that it would be worth keeping consistency between platforms here - if android_run.py were moved to testbed/__main__.py, it would keep the same execution surface as iOS - python Platforms/Android/testbed --connected ...; with the added benefit that the testbed directory becomes a self-contained artefact.
IMHO, ideally, it would have the same external command surface as well - the clone subcommand is really handy for ensuring that you have a "clean" original testbed, and per-project working directory that you can run.
If there are opportunities to consolidate other arguments or details of the command surface, that would be an added bonus.
I agree that would be a good idea eventually, and I already suggested adding the clone command in the linked issue. However, this PR is actually working at a lower level, creating a script which can be used to test any Android app, even one that has nothing to do with Python. I don't think there's any equivalent to that in the Apple directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the first step towards splitting the Android testbed into a separate repository. For this PR, all code still remains in the cpython repository, but we create a "lower-level script" as described in the linked issue, which can be used to run Android apps other than the Python testbed.
For example, you can use the script to run one of the test apps from chaquo/chaquopy#1474: