gh-94107: Make _pydecimal.Context hashable to match _decimal.Context - #158160
Open
nirajan-khatiwada wants to merge 2 commits into
Open
nirajan-khatiwada wants to merge 2 commits into
nirajan-khatiwada wants to merge 2 commits into
Conversation
|
All commit authors signed the Contributor License Agreement. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
In
_decimal.Context, instances are hashable viaobject.__hash__, but_pydecimal.Contextexplicitly disabled hashing with__hash__ = None. Under PEP 399, pure-Python fallback implementations must match the behavior of accelerated C modules.As discussed in issue #94107 by @rhettinger and @mdickinson, this PR removes
__hash__ = Nonein_pydecimal.Contextso that it inheritsobject.__hash__, matching_decimal.Context.__hash__ = Nonefrom_pydecimal.Context.test_context_hashtoUsabilityTestinLib/test/test_decimal.pyto test hashing on both C and Python implementations.Misc/NEWS.d/next/Library/.