Skip to content

gh-158166: Make ElementTree ParseError messages strings #158168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alexprengere wants to merge 3 commits into
base: main
Choose a base branch
from
+7 −1
Open

gh-158166: Make ElementTree ParseError messages strings #158168

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6b5cdcf
gh-158166: Make ElementTree ParseError messages strings
alexprengere Sep 25, 2026
2b37218
Merge branch 'main' into gh-158166-xml-parseerror-difference
alexprengere Sep 26, 2026
d2c2133
📜🤖 Added by blurb_it.
blurb-it[bot] Sep 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1324,6 +1324,11 @@ def test_parse_error_after_chunk_boundary(self):
ET.fromstring('<r>%s<</r>' % ('x' * size))
self.assertEqual(cm.exception.position, (1, size + 4))

def test_parse_error_msg_is_string(self):
with self.assertRaises(ET.ParseError) as cm:
ET.XML("<")
self.assertIsInstance(cm.exception.msg, str)
self.assertEqual(cm.exception.msg, "unclosed token: line 1, column 0")

@support.subTests('sample,exception', [
(b'<x> \xa1</x>', UnicodeDecodeError), # crashed
Expand Down
2 changes: 1 addition & 1 deletion Lib/xml/etree/ElementTree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1709,7 +1709,7 @@ def handler(pi_target, data, event=event_name, append=append,
raise ValueError("unknown event %r" % event_name)

def _raiseerror(self, value):
err = ParseError(value)
err = ParseError(str(value))
err.code = value.code
err.position = value.lineno, value.offset
raise err
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-09-26-09-44-59.gh-issue-158166.lVGCsI.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make pure-Python ElementTree ParseError first argument always a str.
Loading