gh-158225: Fix wsgiref Headers __setitem__ validation order - #158226
Open
Tony123-tech wants to merge 1 commit into
Open
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
Tony123-tech
force-pushed
the
gh-158225-fix-wsgiref-headers-setitem
branch
2 times, most recently
from
September 26, 2026 09:36
4666fad to
91d9761
Compare
Tony123-tech
force-pushed
the
gh-158225-fix-wsgiref-headers-setitem
branch
from
September 26, 2026 09:42
91d9761 to
cabcc7d
Compare
Contributor
|
Hi! I reviewed and tested this change locally. Specifically, I checked that when validation of the new header name or value fails, the existing header value is preserved: from wsgiref.headers import Headers
h = Headers([("Content-Type", "text/html")])
try:
h["Content-Type"] = True
except AssertionError:
pass
assert h.get("Content-Type") == "text/html"I also checked the case where validation of the header name fails because it contains a control character: from wsgiref.headers import Headers
h = Headers([("Content-Type", "text/html")])
try:
h["Content-\x00Type"] = "application/json"
except ValueError:
pass
assert h.get("Content-Type") == "text/html"In both cases, the existing header remains unchanged. I also ran the relevant test suite: I didn't find any issues with the change in these checks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.