Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/email/encoders.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ def encode_base64(msg):
orig = msg.get_payload(decode=True)
encdata = str(_bencode(orig), 'ascii')
msg.set_payload(encdata)
del msg['Content-Transfer-Encoding']
msg['Content-Transfer-Encoding'] = 'base64'


Expand All @@ -41,6 +42,7 @@ def encode_quopri(msg):
orig = msg.get_payload(decode=True)
encdata = _qencode(orig)
msg.set_payload(encdata)
del msg['Content-Transfer-Encoding']
msg['Content-Transfer-Encoding'] = 'quoted-printable'


Expand Down
14 changes: 14 additions & 0 deletions Lib/test/test_email/test_email.py
Original file line number Diff line number Diff line change
Expand Up @@ -916,6 +916,20 @@ def test_default_cte(self):
msg = MIMEText('hello \xf8 world', _charset='iso-8859-1')
eq(msg['content-transfer-encoding'], 'quoted-printable')

def test_encode_replaces_existing_cte(self):
# gh-43702: re-encoding must replace the old Content-Transfer-Encoding
# header, not add a second one.
for charset, encoder, cte in (
('iso-8859-1', encoders.encode_base64, 'base64'),
('utf-8', encoders.encode_quopri, 'quoted-printable')):
with self.subTest(cte=cte):
msg = MIMEText('h\xe9llo', _charset=charset)
encoder(msg)
self.assertEqual(msg.get_all('content-transfer-encoding'),
[cte])
self.assertEqual(msg.get_payload(decode=True),
'h\xe9llo'.encode(charset))

def test_encode7or8bit(self):
# Make sure a charset whose input character set is 8bit but
# whose output character set is 7bit gets a transfer-encoding
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Fix :func:`email.encoders.encode_base64` and
:func:`email.encoders.encode_quopri` adding a second
:mailheader:`Content-Transfer-Encoding` header when they re-encode a
message that already has one.
Loading