gh-158237: Don't insert space before attribute access on bool constants - #158238
Merged
JelleZijlstra merged 1 commit intoSep 26, 2026
Merged
Conversation
Tony123-tech
requested review from
Eclips4,
JelleZijlstra,
isidentical and
tomasr8
as code owners
September 26, 2026 14:06
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Tony123-tech
force-pushed
the
gh-158237-fix-unparse-bool-attribute
branch
from
September 26, 2026 14:07
05dd309 to
aca1577
Compare
Tony123-tech
force-pushed
the
gh-158237-fix-unparse-bool-attribute
branch
from
September 26, 2026 14:09
aca1577 to
edad754
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lib/_ast_unparse.py's visit_Attribute inserts a space before the "."
when node.value is an int literal, to avoid the syntax error in
3.abs(). But bool is a subclass of int, so True.real and
False.class also get the space:
True.real and False.class are valid without a space, so the
output is not idiomatic. The fix excludes bool from the isinstance
check.