gh-158320: Reject optional groups with a var-positional parameter in Argument Clinic - #158323
Merged
serhiy-storchaka merged 1 commit intoSep 28, 2026
Merged
Conversation
…er in Argument Clinic Such a combination is ambiguous: the number of arguments does not tell whether the group is passed or all arguments belong to the var-positional parameter.
serhiy-storchaka
requested review from
AA-Turner and
erlend-aasland
as code owners
September 28, 2026 08:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Argument Clinic crashed with
ValueError: required is empty but left is notif an optional group preceded a var-positional parameter, and reported a confusing error about positional-only parameters in the opposite order.Both orders now fail with: