gh-158294: Avoid relying on SystemTap probe handler ordering - #158346
Conversation
Merge the tracing state and filter output in a single probe handler as SystemTap does not guarantee the execution order of handlers sharing a probe point.
|
🤖 New build scheduled with the buildbot fleet by @hugovk for commit c519ba7 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F158346%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
hugovk
left a comment
There was a problem hiding this comment.
The six builders that failed in #158294 now pass here:
- https://buildbot.python.org/#/builders/1634/builds/580
- https://buildbot.python.org/#/builders/1666/builds/580
- https://buildbot.python.org/#/builders/1643/builds/581
- https://buildbot.python.org/#/builders/1640/builds/583
- https://buildbot.python.org/#/builders/1652/builds/584
- https://buildbot.python.org/#/builders/1630/builds/675
The "buildbot/AMD64 Windows PGO NoGIL PR" failure is unrelated:
|
Backport needed at least for 3.15 where this is failing (for example, https://buildbot.python.org/#/builders/2016/builds/413). |
|
Thanks @stratakis for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15. |
|
GH-158383 is a backport of this pull request to the 3.15 branch. |
|
Thanks for the quick fix @stratakis! |
Merge the tracing state and filter output in a single probe handler as SystemTap does not guarantee the execution order of handlers sharing a probe point.
test_dtracefails on s390x Fedora buildbots #158294