gh-158398: Clear unconsumed_tail at end of stream - #158408
Closed
Tony123-tech wants to merge 1 commit into
Closed
Tony123-tech wants to merge 1 commit into
Tony123-tech wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #158398.
The test
test_decompress_unconsumed_tail_after_eof(added in gh-158169 / #158177) fails on main:Root cause: gh-158169 added
self->zst.next_in += left_size;tosave_unconsumed_input(), which advancesnext_inbefore the following block computes the remaining input length. This makes the computation wrong, sounconsumed_tailis not cleared at end of stream.Changes:
self->zst.next_in += left_size;line.unconsumed_tailexplicitly whenZ_STREAM_ENDis reached.else ifso it is not entered at end of stream.