Conversation
This is based on python#146304, but fixes a concurrency issue where `future` is accessed unsafely. Co-authored-by: VanshAgarwal24036 <148854295+VanshAgarwal24036@users.noreply.github.com> Co-authored-by: Victor Stinner <vstinner@python.org>
msullivan
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
September 30, 2026 02:03
This was referenced Sep 30, 2026
This just gets rid of any confusion about why FutureIter_clear is using a critical section
msullivan
force-pushed
the
gh-146065-fix-futureiter-null-deref-take-2
branch
from
September 30, 2026 17:37
287d4df to
d51862b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #146304, but fixes a concurrency issue where
futureis accessed unsafely.NULLpointer dereference inFutureIter_am_send#146065