gh-158683: Fix missing source files for _zstd in Modules/Setup

[maxyz]

The _zstd module also requires _zstd/zstddict.c, _zstd/compressor.c, and _zstd/decompressor.c.

• Issue: Incomplete source file list for _zstd in Modules/Setup #158683

[python-cla-bot]

All commit authors signed the Contributor License Agreement.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[maxyz]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

I consider this change trivial, thus no issue nor added news.

[picnixz]

I consider this change trivial, thus no issue nor added news.

Sorry, but the triviality of a change is at a maintainer's discretion. Have you experienced an issue with the build with the original configuration? if so, please just open an issue with the traceback and what you did so that we can have an historical note. And a NEWS entry is still required since custom builds would now be correct I guess?

[StanFromIreland]

This just changes comments in an example, I don't see a need for a blurb. The list actually used is correct:

cpython/Modules/Setup.stdlib.in

Line 67 in 83b40d0

@MODULE__ZSTD_TRUE@_zstd _zstd/_zstdmodule.c _zstd/zstddict.c _zstd/compressor.c _zstd/decompressor.c

[picnixz]

This just changes comments in an example

It's not an example, it's the template that users can use for their local dev I think? or even for local builds and shipping I think?

[picnixz]

Wait, if it's just an example, I wonder why we have it? why not having it in the docs instead?

[StanFromIreland]

Oh no, sorry. I was a little mistaken, I thought we told people to just use this as an example/template (which we kind of do), but at the same time we do also tell them to use it:

cpython/Modules/Setup

Lines 80 to 83 in 1b015e6

	# NOTE: Avoid editing this file directly. Local changes should go into
	# Modules/Setup.local file. To enable all modules for testing, run
	#
	# sed -n -E 's/^#([a-z_\*].*)$/\1/p' Modules/Setup > Modules/Setup.local

I suppose this deserves a news entry then.

[bedevere-app]

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

[maxyz]

Thanks for the reviewing, I submitted the issue and added the news. Please take another look.

[encukou]

LGTM, thank you.
I'll merge ~tomorrow if there are no objections.

[StanFromIreland]

LGTM (bar a little nit for the blurb).

[maxyz]

Applied the nit, thanks for the review.

[miss-islington-app]

Thanks @maxyz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

[miss-islington-app]

Thanks @maxyz for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[bedevere-app]

GH-159055 is a backport of this pull request to the 3.14 branch.

[bedevere-app]

GH-159056 is a backport of this pull request to the 3.15 branch.