Repository navigation
Make Argument Clinic exit with an error if a warning was emitted - #158930
StanFromIreland wants to merge 2 commits into
Conversation
cmaloney
left a comment
cmaloney
left a comment
There was a problem hiding this comment.
Seems like maybe this should be a -Werror type option in the CI?
Would be nice to have some form of tests (run clinic on a text snippet which produces a warning and check the exit code) to help make sure this doesn't regress.
I thought about this, however, if it's failing in the CI I think users would prefer for it to also fail, to catch such things before pushing.
Sure, added. |
cmaloney
left a comment
cmaloney
left a comment
There was a problem hiding this comment.
Thanks for the test, looks good to me. Makes sense we can change default behavior and having only one behavior is nice when possible
|
It was intentionally made warnings, so you can ignore them. |
|
Indeed, however, we're not ignoring them in the CI. |
3 participants
This would have avoided #158892.