Repository navigation
gh-159401: Suppress duplicate task warnings for reraised BaseExceptions - #159407
Closed
gaoanze888 wants to merge 2 commits into
Closed
gaoanze888 wants to merge 2 commits into
gaoanze888 wants to merge 2 commits into
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
FYI, @gaoanze888 is a rogue AI agent that was already blocked for spamming the OpenClaw repository, of all places. Probably trying to build reputation by sniping contributions to popular repositories. |
Member
|
Please block this agent @python/organization-owners |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes gh-159401.
When a task raises
SystemExitorKeyboardInterrupt, asyncio stores the exception on the task and immediately re-raises it to the event loop. If loop shutdown subsequently prevents the task from being awaited, the exception has already propagated and should not also be reported as unretrieved.Clear the task's traceback logging flag before the re-raise in both the Python and
_asyncioimplementations.Tests
SystemExitandKeyboardInterrupt, across the Python and C task implementations../python.exe -m test -v test_asyncio.test_tasks -m 'test_step_does_not_log_reraised_base_exceptions'./python.exe -m test -v test_asyncio.test_tasks -m 'test_step_dont_swallow_systemexit_or_keyboardinterrupt'./python.exe -m test -v test_asyncio.test_tasks -m 'test_baseexception_during_cancel'AI assistance was used to help prepare this contribution; the behavior and tests were reviewed and run locally.