Skip to content

gh-56596: IDLE keyboard shortcuts function irespective of caps-lock state #32245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ringof wants to merge 4 commits into from
+10 −17
Closed

gh-56596: IDLE keyboard shortcuts function irespective of caps-lock state #32245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b30861
bpo-12387: IDLE keyboard shortcuts work for non-Darwin systems irresp…
ringof Apr 2, 2022
71dd09f
patchcheck fixes
ringof Apr 2, 2022
ee199cb
Merge branch 'main' into bpo-12387-IDLE-save-shortcut
ringof Jun 18, 2023
dbbf669
Merge branch 'main' into bpo-12387-IDLE-save-shortcut
ringof Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/idlelib/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@
from configparser import ConfigParser
import os
import sys
import re

from tkinter.font import Font
import idlelib
Expand Down Expand Up @@ -587,6 +588,15 @@ def GetCurrentKeySet(self):
v2 = [ x.replace('<Alt-', '<Option-') for x in v ]
if v != v2:
result[k] = v2
else:
def replace(m):
return m.group('prefix') + m.group('alpha').swapcase()+'>'

pat = '(?P<prefix><[A-Za-z-]+Key-)(?P<alpha>[a-zA-Z])>'
for k, v in result.items():
v2 = [re.sub(pat, replace, x) for x in v]
if v != v2:
v.extend(v2)

return result

Expand Down
17 changes: 0 additions & 17 deletions Lib/idlelib/idle_test/test_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -488,23 +488,6 @@ def test_get_keybinding(self):
eq(conf.GetKeyBinding('NOT EXISTS', '<<copy>>'), [])
eq(conf.GetKeyBinding('IDLE Modern Unix', 'NOT EXISTS'), [])

def test_get_current_keyset(self):
current_platform = sys.platform
conf = self.mock_config()

# Ensure that platform isn't darwin
sys.platform = 'some-linux'
self.assertEqual(conf.GetCurrentKeySet(), conf.GetKeySet(conf.CurrentKeys()))

# This should not be the same, since replace <Alt- to <Option-.
# Above depended on config-extensions.def having Alt keys,
# which is no longer true.
# sys.platform = 'darwin'
# self.assertNotEqual(conf.GetCurrentKeySet(), conf.GetKeySet(conf.CurrentKeys()))

# Restore platform
sys.platform = current_platform

def test_get_keyset(self):
conf = self.mock_config()

Expand Down
Loading