Skip to content

Fixes welcome message and alias display - #417

Merged
zooba merged 3 commits into
python:mainfrom
zooba:welcome
Sep 15, 2026
Merged

zooba merged 3 commits into
python:mainfrom
zooba:welcome

Conversation

@zooba

@zooba zooba commented Sep 14, 2026

Copy link
Copy Markdown
Member

Also adds ruff.toml to exclude noisy rules.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Welcome messaging can use the host architecture instead of the configured default platform.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates welcome messaging and platform-aware alias display, with Ruff configuration cleanup.

Changes:

  • Adds changelog and ARM64-specific welcome messages.
  • Formats aliases relative to the configured default platform.
  • Updates related tests and Ruff settings.
File summaries
File Summary
tests/test_list.py Updates alias display expectations.
tests/test_installs.py Tests default-platform alias formatting.
tests/test_install_command.py Updates command test platform setup.
src/manage/scriptutils.py Removes an unused exception binding.
src/manage/installs.py Implements platform-aware alias formatting.
src/manage/install_command.py Passes the configured platform to alias formatting.
src/manage/commands.py Adds changelog and platform-specific welcome messages.
ruff.toml Configures ignored Ruff rules.
Review details

Suppressed comments (1)

src/manage/commands.py:548

  • The new architecture-specific branch is not covered by the test suite: tests/conftest.py sets commands.WELCOME = "", so show_welcome() returns before this line in every test, and no test exercises either architecture-specific message. Please add focused coverage that mocks the architecture and verifies both the ARM64 and non-ARM64 messages.
        if get_processor_architecture() == "-arm64":
  • Files reviewed: 8/8 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread src/manage/commands.py
@zooba
zooba merged commit c25ec7e into python:main Sep 15, 2026
6 checks passed
@zooba
zooba deleted the welcome branch September 15, 2026 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants