Skip to content

Vulkan: register the missing logical_not runtime op #22786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
msluszniak wants to merge 2 commits into from
Closed

Vulkan: register the missing logical_not runtime op #22786

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e162934
Vulkan: register the missing logical_not runtime op
msluszniak Sep 13, 2026
81d875d
Update backends/vulkan/runtime/graph/ops/impl/UnaryOp.cpp
msluszniak Sep 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/vulkan/runtime/graph/ops/impl/UnaryOp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -227,6 +227,7 @@ REGISTER_OPERATORS {
VK_REGISTER_OP(aten.log10.default, log10);
VK_REGISTER_OP(aten.round.default, round);
VK_REGISTER_OP(aten.bitwise_not.default, bitwise_not);
VK_REGISTER_OP(aten.logical_not.default, bitwise_not);
}

} // namespace vkcompute
12 changes: 12 additions & 0 deletions backends/vulkan/test/test_vulkan_delegate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,18 @@ def forward(self, x):

self.lower_unary_module_and_test_output(TanhModule())

def test_vulkan_backend_logical_not(self):
class LogicalNotModule(torch.nn.Module):
def __init__(self):
super().__init__()

def forward(self, x):
# logical_not produces a boolean tensor, which cannot be
# compared with torch.allclose, so select through it instead.
return torch.where(torch.logical_not(x > 0), x, torch.zeros_like(x))

self.lower_unary_module_and_test_output(LogicalNotModule())

def test_vulkan_backend_linear(self):
class LinearModule(torch.nn.Module):
def __init__(self):
Expand Down
Loading