Repository navigation
Arm backend: Relax SymbolicShapeSupport-checks - #22826
Merged
oscarandersson8218 merged 1 commit intoSep 15, 2026
Merged
oscarandersson8218 merged 1 commit into
oscarandersson8218 merged 1 commit into
Conversation
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization. Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead. For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes. Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> Change-Id: I1a65d72ceea18a9b5e08779c2987cdd44b70a589
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22826
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ 1 Pending, 4 Unrelated FailuresAs of commit f8983a9 with merge base 4798a67 ( FLAKY - The following jobs failed but were likely due to flakiness present on trunk:
BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
Sebastian-Larsson
approved these changes
Sep 15, 2026
zingo
approved these changes
Sep 15, 2026
Collaborator
Author
|
Unrelated failures. |
Collaborator
Author
|
@pytorchbot cherry-pick --onto release/1.5 -c regression |
Collaborator
Cherry picking #22826The cherry pick PR is at #22834 and it is recommended to link a regression cherry pick PR with an issue. The following tracker issues are updated: Details for Dev Infra teamRaised by workflow job |
Contributor
Release is going out in a couple hours and CI is very red so I'm not planning on merging this one. |
JacobSzwejbka
pushed a commit
that referenced
this pull request
Sep 17, 2026
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization. Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead. For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes. cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> (cherry picked from commit 1498f7a)
JacobSzwejbka
pushed a commit
that referenced
this pull request
Sep 17, 2026
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization. Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead. For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes. cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani Signed-off-by: Oscar Andersson <oscar.andersson@arm.com> (cherry picked from commit 1498f7a)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow TOSA support checks to distinguish between symbolic tensor metadata and symbolic shape materialization.
Without the TOSA shape extension, symbolic tensor input/output shapes can still be accepted for ops whose lowering does not need materialized shape values. Reject symbolic SymInt arguments and the known shape- dependent edge cases instead.
For targets that require fully resolved tensor shapes, add a separate partitioner-level check that rejects nodes with unresolved tensor input or output shapes.
cc @digantdesai @freddan80 @per @zingo @mansnils @Sebastian-Larsson @robell @rascani