Cortex-M: size scratch buffers in a dedicated pass - #22860
Merged
Merged
Conversation
Contributor
Author
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/22860
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 57305bb with merge base 026ca3f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Sep 15, 2026
rascani
marked this pull request as ready for review
September 16, 2026 17:30
rascani
added a commit
that referenced
this pull request
Sep 16, 2026
Move CMSIS-NN scratch allocation sizing out of AtenToCortexMPass into InitializeScratchBuffersPass. Run it immediately after dialect lowering in both default pipelines. This lets later graph rewrites, such as padding fusion, run before sizing without embedding them in dialect conversion. Preserve target-specific sizing, metadata updates and validation of trailing allocation nodes. Recompile after changing allocation arguments. Explicit custom pipelines that perform dialect lowering must include the sizing pass before memory planning. The extraction is independently reviewed; existing convolution, pooling, layout and DS-CNN dialect tests exercise both pipelines. Authored with AI assistance from Codex. ghstack-source-id: 238c20d ghstack-comment-id: 5689271806 Pull-Request: #22860
JakeStevens
approved these changes
Sep 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move CMSIS-NN scratch allocation sizing out of AtenToCortexMPass into InitializeScratchBuffersPass. Run it immediately after dialect lowering in both default pipelines. This lets later graph rewrites, such as padding fusion, run before sizing without embedding them in dialect conversion.
Preserve target-specific sizing, metadata updates and validation of trailing allocation nodes. Recompile after changing allocation arguments. Explicit custom pipelines that perform dialect lowering must include the sizing pass before memory planning. The extraction is independently reviewed; existing convolution, pooling, layout and DS-CNN dialect tests exercise both pipelines.
Authored with AI assistance from Codex.