Repository navigation
[Vulkan] Delegate aten.mul.Scalar - #23213
Closed
mergennachin wants to merge 1 commit into
Closed
mergennachin wants to merge 1 commit into
mergennachin wants to merge 1 commit into
Conversation
Tensor-times-scalar products appear in attention scaling and were kept on CPU, splitting otherwise fully delegated blocks. This adds a mul variant to the binary scalar shaders and registers it with pow.Tensor_Scalar under a shared op_registry entry that applies the same scalar-value guard. Authored with OpenAI Codex; split planned with Claude Code.
pytorch-bot
Bot
added
the
module: vulkan
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/23213
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 35ddf0b with merge base a318382 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
This was referenced Sep 28, 2026
mergennachin
added a commit
that referenced
this pull request
Oct 8, 2026
Tensor-times-scalar products appear in attention scaling and were kept on CPU, splitting otherwise fully delegated blocks. Add a mul variant to the binary scalar shaders and register it with pow.Tensor_Scalar under the shared scalar-value guard. FP16 mul.Scalar rounds each result to half on every device, including devices that emulate FP16 storage with FP32. A regression test keeps two mul.Scalar nodes inside one delegate and checks intermediate rounding with exact ATen output comparison for texture and buffer storage. Part 13/15 of the Vulkan transformer and operator-conformance stack. #23251 has landed; this PR is rebased directly onto `origin/main` at `286643dbb2`. Integration PR: #23254. Test Plan: Rebuilt ExecuTorch with Vulkan enabled from the rebased source on macOS arm64. Ran `TestVulkanDynamic.test_signed_zero_scalars` and `TestVulkanDynamic.test_fp16_chained_mul_scalar` through the public Buck Python test adapter with each driver ICD explicitly selected. SwiftShader passed both tests and all 6 subcases in 15.542s; MoltenVK passed both tests and all 6 subcases in 15.620s. Both runs had zero failures, errors, or skips. Coverage includes signed-zero preservation for FP32/FP16 and exact intermediate FP16 rounding with two mul.Scalar nodes in one delegate, using both texture and buffer storage. SwiftShader exercises FP16 storage emulation. Lintrunner on all 6 changed files, `git diff --check`, and `pip check` passed. Recreates #23213 through ghstack. Prior review discussion remains on that PR. Authored with OpenAI Codex; split planned with Claude Code. cc @SS-JIA @manuelcandales @digantdesai @cbilgin
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #23252, part 13/15 of the ghstack replacement series. The current integration PR is #23254. This PR is closed in favor of the replacement; its previous description and review history are retained.
Tensor-times-scalar products appear in attention scaling and were kept on CPU, splitting otherwise fully delegated blocks. This adds a mul variant to the binary scalar shaders and registers it with pow.Tensor_Scalar under a shared op_registry entry that applies the same scalar-value guard.
Part 13/15 of the Vulkan transformer and operator-conformance stack. Depends on #23212; review against the selected base branch. Integration PR: #23162.
Validation: 1 passed, 2 warnings in 10.21s. Lintrunner and git diff --check pass. Native tests use MoltenVK with portable CPU kernels; hardware and SwiftShader CI are pending.
Authored with OpenAI Codex; split planned with Claude Code.
cc @SS-JIA @manuelcandales @digantdesai @cbilgin