Add IMAP peek header fetch - #120
Merged
Merged
Conversation
mpscholten
force-pushed
the
codex/fetch-peek-header
branch
from
June 26, 2026 14:05
0e0a90b to
030ced6
Compare
Contributor
Author
|
@qnikst is this good to go? |
Owner
|
Commit definitely looks great and I’m happy to have that, thanks! Warning by stack surprised me, I was not aware of so cool GitHub feature (even it’s duplicatef multiple times). But the code is that place looks very suspicious.. it’s definitely not for this PR but I’m curious is the same could not be written in terms of BS.span |
qnikst
marked this pull request as ready for review
August 8, 2026 15:33
qnikst
approved these changes
Aug 8, 2026
Owner
|
I would be happy to merge if you are ok (PR was in draft, so I’m not sure) |
Contributor
Author
|
Thanks, forgot to move from draft to full PR :D it's good to go |
Owner
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
add
fetchPeekHeaderforBODY.PEEK[HEADER]IMAP header fetches without setting\\Seenadd parser coverage for the new helper using the scripted IMAP connection
Validation
cabal test imap-parsers