Skip to content

Replace deprecated ExecType values in Executor application - #1296

Open
chrjohn wants to merge 4 commits into
copilot/remove-full-minimal-fix-distinctionfrom
chrjohn-deprecated-exectype-values
Open

chrjohn wants to merge 4 commits into
copilot/remove-full-minimal-fix-distinctionfrom
chrjohn-deprecated-exectype-values

Conversation

@chrjohn

@chrjohn chrjohn commented Aug 3, 2026 •

Copy link
Copy Markdown
Member

ExecType values 1/PARTIAL_FILL and 2/FILL are deprecated since FIX4.4.
When switching to the full-fix-latest profile, these values will be gone.
So for the Executor application we need to pass these values as literal value since the quickfix.field package only contains the fields and values from the most recent FIX version (i.e. FIXLatest). In prior QFJ versions this behaviour was different since the FIX dictionaries (from which the field classes were generated) were manually changed to still contain ExecType values 1 and 2. Example:

<field number="150" name="ExecType" type="CHAR">
<value enum="0" description="NEW"/>
<!-- MODIFIED: values 1 and 2 were removed from the spec,
but are added here in order for the code generator to work -->
<value enum="1" description="PARTIAL_FILL"/>
<value enum="2" description="FILL"/>

@codecov

codecov Bot commented Aug 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (copilot/remove-full-minimal-fix-distinction@ec075b2). Learn more about missing BASE report.

Additional details and impacted files
@@                              Coverage Diff                               @@
##             copilot/remove-full-minimal-fix-distinction    #1296   +/-   ##
==============================================================================
  Coverage                                               ?   70.82%           
  Complexity                                             ?     2273           
==============================================================================
  Files                                                  ?      161           
  Lines                                                  ?     9077           
  Branches                                               ?     1192           
==============================================================================
  Hits                                                   ?     6429           
  Misses                                                 ?     2197           
  Partials                                               ?      451           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Values 1 and 2 are deprecated since FIX4.4.
@chrjohn
chrjohn force-pushed the chrjohn-deprecated-exectype-values branch from d57e32f to 74b6529 Compare August 3, 2026 11:14
@chrjohn
chrjohn added this pull request to stack #1333 September 25, 2026 08:13
@chrjohn
chrjohn removed this pull request from stack #1333 September 25, 2026 08:14
@chrjohn
chrjohn added this pull request to stack #1334 September 25, 2026 09:23

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant