remove envvar printing from check_built() - #2621
Merged
Merged
Conversation
tanho63
changed the title
check_built() check_built()
hadley
reviewed
Sep 26, 2025
Member
|
Only need to merge this if we merge the related rcmdcheck change and this ensures that we don't print the same env vars multiple times. |
tanho63
force-pushed
the
tan/tdd-rcmdcheck-237
branch
3 times, most recently
from
September 17, 2026 16:33
a62f9a9 to
20434b3
Compare
Updated NEWS.md to reflect changes in devtools, including new functions and behavioral updates.
Contributor
Author
|
note that once rcmdcheck#237 is merged we should remove the hardcoded PR reference in DESCRIPTION/Remotes |
This comment was marked as resolved.
This comment was marked as resolved.
Member
|
Looks like Jenny fixed that in e604714 |
Contributor
Author
Whoops, you're right! |
Contributor
Author
|
I think this is good to go when rcmdcheck#237 is good to go then? |
tanho63
commented
Sep 24, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[tidy dev day 2025] part of r-lib/rcmdcheck#237:
rcmdcheck::rcmdcheck()now prints all associated r check environment variables as well as not cran, so we can remove this feature fromdevtools::check().