ASoC: dwc: Revert i2s_stop to the upstream version - #7588
Merged
Merged
Conversation
Since we started using the DWC I2S block in RP1, the upstream driver has improved a lot. Drop the downstream version of i2s_stop, which avoided clearing ITER and IRER in order to not block DMA, now that upstream uses i2s_disable_dma. See: raspberrypi#7584 Signed-off-by: Phil Elwell <phil@raspberrypi.com>
Contributor
|
Thanks for the fix here — and credit to Hyeonsu Cho (reporter on #7584) for running it through a proper validation: 100 consecutive induced XRUN/underrun cycles on a Pi 5 + HiFiBerry DAC8x (8-channel ALSA playback, 44.1kHz), all 100 recovering cleanly via @pelwell: in our opinion this can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we started using the DWC I2S block in RP1, the upstream driver has improved a lot. Drop the downstream version of i2s_stop, which avoided clearing ITER and IRER in order to not block DMA, now that upstream uses i2s_disable_dma.
See: #7584