IMX585 fixups to Starvis2 driver - #7668
Merged
Merged
Conversation
pelwell
approved these changes
Oct 1, 2026
pelwell
left a comment
pelwell
left a comment
Contributor
There was a problem hiding this comment.
Change the Fixes: tag to use a 12-digit hash, then merge at will.
IMX585 requires bit 4 of the WINMODE register (0x3018) to be set, whilst the bottom nibble selects between all-pixel and window mode. Switch to using cci_update_bits so that only the bottom nibble is updated, thereby working on all supported Starvis2 sensors. Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
The common registers and minimum HMAX values merged for IMX585 were incorrect. Validate against the information from Sony, and confirmed working. Fixes: bcb59d4 ("media: sony-starvis2: Add support for IMX585") Signed-off-by: Dave Stevenson <dave.stevenson@raspberrypi.com>
6by9
force-pushed
the
rpi-6.18.y-starvis2
branch
from
October 1, 2026 10:38
2474600 to
f67232a
Compare
Contributor
Author
|
Well that's weird. I have a ... Ah, https://git-scm.com/docs/pretty-formats#Documentation/pretty-formats.txt-abbrevnumber I guess I've got more objects in my repo now. Updated. That hash is only on our rpi-6.18.y branch, so it wasn't too critical anyway. It'll get squashed when I submit upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixups now that I've got an IMX585 module.