build: pin packageManager to yarn 1.22.22 - #820
Conversation
The repo ships a yarn 1 lockfile but corepack defaulted to yarn 4, so install and any make target invoking `yarn bin` failed until npx yarn@1.22.22 was used. corepack now resolves explicitly.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe package manifest now declares Yarn version 1.22.22 through the ChangesPackage manager metadata
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to This change pins the compatible Yarn version and introduces no concrete merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
package.jsonESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Corepack defaults to yarn 4 because nothing pins the version, but the repo ships a yarn 1 lockfile. Consequence:
yarn installfails with YN0028 (lockfile would be modified), and everymaketarget that callsexport BIN := $(shell yarn bin)dies before make can do anything, which surfaces as a misleadingMakefile:32: multiple target patternserror under GNU Make 3.81 after the failed $(shell) leaves BIN empty.Fix: one line,
"packageManager": "yarn@1.22.22"in package.json. corepack now resolves to yarn 1 and bothyarn installandmake build/make testrun as-is.No other changes. Verified locally: yarn --version → 1.22.22, make build passes the build-contract check, 204/204 tests.
Summary by CodeRabbit