Skip to content

build: pin packageManager to yarn 1.22.22 - #820

Merged
STRML merged 1 commit into
masterfrom
fix/build-tooling
Sep 16, 2026
Merged

STRML merged 1 commit into
masterfrom
fix/build-tooling

Conversation

@STRML

@STRML STRML commented Sep 16, 2026

Copy link
Copy Markdown
Collaborator

Corepack defaults to yarn 4 because nothing pins the version, but the repo ships a yarn 1 lockfile. Consequence: yarn install fails with YN0028 (lockfile would be modified), and every make target that calls export BIN := $(shell yarn bin) dies before make can do anything, which surfaces as a misleading Makefile:32: multiple target patterns error under GNU Make 3.81 after the failed $(shell) leaves BIN empty.

Fix: one line, "packageManager": "yarn@1.22.22" in package.json. corepack now resolves to yarn 1 and both yarn install and make build/make test run as-is.

No other changes. Verified locally: yarn --version → 1.22.22, make build passes the build-contract check, 204/204 tests.

Summary by CodeRabbit

  • Chores
    • Specified Yarn version 1.22.22 for project tooling consistency.

The repo ships a yarn 1 lockfile but corepack defaulted to yarn 4, so
install and any make target invoking `yarn bin` failed until npx
yarn@1.22.22 was used. corepack now resolves explicitly.
@coderabbitai

coderabbitai Bot commented Sep 16, 2026

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 20f90ee7-34f4-4e27-bda0-9e8d28f65675

📥 Commits

Reviewing files that changed from the base of the PR and between 01989d2 and 2970b72.

📒 Files selected for processing (1)
  • package.json

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The package manifest now declares Yarn version 1.22.22 through the packageManager field.

Changes

Package manager metadata

Layer / File(s) Summary
Yarn declaration
package.json
Adds the packageManager field with Yarn version 1.22.22.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: binhpv

Merge Risk: ⚪ Minimal · up to 2970b

This change pins the compatible Yarn version and introduces no concrete merge-blocking risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: pinning the package manager to Yarn 1.22.22.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/build-tooling

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

package.json

ESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@STRML
STRML merged commit 194ecfc into master Sep 16, 2026
7 checks passed
@STRML
STRML deleted the fix/build-tooling branch September 16, 2026 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant