chore: restore missing security resolutions + close esbuild/uuid alerts - #823
Conversation
PR #821's package.json hunk lost the js-yaml/fast-uri resolutions to a bad working-tree state, so a fresh resolve would regress to vulnerable 4.3.0/3.1.4. Restore those and add esbuild ^0.28.2 (#139) and uuid ^11.1.1 (#130), the two alerts filed after #821. All dev-only. Verify: make build (contract OK), make lint clean, 204/204 tests, node_modules = js-yaml 4.3.2 / fast-uri 3.1.8 / esbuild 0.28.2 / uuid 11.1.1.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 6 remain after this review. 📝 WalkthroughWalkthroughThe package resolutions add four transitive-dependency version overrides. The existing ChangesDependency Resolution
Priority: ➖ Normal Estimated code review effort: 1 (Trivial) | ~3 minutes Change: Other Suggested reviewers: Merge Risk: ⚪ Minimal · up to The dependency updates address the reported vulnerable transitive versions without an identified functional regression, so the change is mergeable. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
package.jsonESLint skipped: missing config or dependency (missing-dependency). The ESLint configuration references a package that is not available in the sandbox. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Two things:
js-yaml/fast-uriresolutions to a bad working-tree state before commit; only the yarn.lock pins landed, so a freshyarn install --regenerate-lockfilewould regress to vulnerable js-yaml 4.3.0 / fast-uri 3.1.4. This restores them as source-of-truth resolutions.^0.28.2and uuid (via webpack-dev-server → sockjs, unmount during drag causes invariant throw #130) →^11.1.1.All dev-only. tsup builds clean on esbuild 0.28.2 and sockjs's
require('uuid').v4is compatible with uuid 11.Verified:
make buildcontract OK,make lintclean, 204/204 tests, node_modules resolves to js-yaml 4.3.2 / fast-uri 3.1.8 / esbuild 0.28.2 / uuid 11.1.1.Summary by CodeRabbit