Skip to content

Bump Release for Node 18.20 Memory Leak fix #219

Description

@TiKevin83

We use this image for CI builds of React Native, can we bump out a release to use at least Node 18.20? I'm getting 18.19 in my CI pipeline and there's a critical fix in 18.20 for a memory leak in Jest tests that has been out there for 2.5 years and requiring running Jest with --workerIdleMemoryLimit set to a low number like 100mb to prevent OOMs in the CI runner.

jestjs/jest#11956
https://nodejs.org/en/blog/release/v18.20.0#vm-fix-v8-compilation-cache-support-for-vmscript

Activity

  1. changed the title [-]Bump Release for Node 18.20[/-] [+]Bump Release for Node 18.20 Memory Leak fix[/+] on Apr 15, 2024
  2. TiKevin83 commented on Jun 12, 2024

    @TiKevin83
    ContributorAuthor

    @cortinico @tuncaulubilge are you able to rebuild and redeploy the image to get this resolved?

  3. cortinico commented on Jun 12, 2024

    @cortinico
    Member

    Please send a PR that bumps the Node version and if the CI is green we can merge it

  4. TiKevin83 commented on Jun 12, 2024

    @TiKevin83
    ContributorAuthor

    Please send a PR that bumps the Node version and if the CI is green we can merge it

    As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

  5. cortinico commented on Jun 12, 2024

    @cortinico
    Member

    As far as I see the Node version is only specific to the major version 18, just I just go ahead and PR bumping it to the active LTS 20?

    Nope we can't bump Node to 20 as of now.
    We'll have to bump it to 18.20 and make sure that the download script keeps on working correctly.

  6. TiKevin83 commented on Jun 12, 2024

    @TiKevin83
    ContributorAuthor

    Ok I see the N script should be able to handle 18.20 vs 18 - PRed here
    #225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions