Skip to content

chore(android): apply shared prop validation on Android #1060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vonovak merged 3 commits into from
Sep 7, 2026
Merged

chore(android): apply shared prop validation on Android #1060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d640f4a
fix(android): apply shared prop validation on Android
giaBaoJS Sep 5, 2026
e6dd450
Merge branch 'master' into fix/android-shared-props-validation
vonovak Sep 7, 2026
b212690
Remove duplicate import in index.test.js
vonovak Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/androidUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,13 @@ function getOpenPicker(
}

function validateAndroidProps(props: AndroidNativeProps) {
sharedPropsValidation({value: props?.value});
sharedPropsValidation({
value: props?.value,
timeZoneName: props?.timeZoneName,
timeZoneOffsetInMinutes: props?.timeZoneOffsetInMinutes,
minimumDate: props?.minimumDate,
maximumDate: props?.maximumDate,
});

if (props.design !== 'material') validateMaterial3PropsNotUsed(props);

Expand Down
27 changes: 26 additions & 1 deletion test/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ import RNDateTimePickerWindows, {
RNDateTimePickerWindows as NativeDateTimePickerWindows,
} from '../src/datetimepicker.windows';
import RNDateTimePickerAndroid from '../src/datetimepicker.android';
import {DateTimePickerAndroid} from '../src/DateTimePickerAndroid.android';
import NativeDateTimePickerIOS from '../src/picker.ios';
import {DateTimePickerAndroid} from '../src/DateTimePickerAndroid';
import {render, fireEvent, waitFor} from '@testing-library/react-native';
import {EVENT_TYPE_SET} from '../src/constants';

Expand Down Expand Up @@ -56,6 +56,31 @@ describe('DateTimePicker', () => {
expect(() => RNDateTimePickerAndroid(props)).toThrow(expected);
});

it.each([
[
{
value: new Date('2023-06-15'),
minimumDate: new Date('2023-12-31'),
maximumDate: new Date('2023-01-01'),
},
'DateTimePicker: minimumDate (2023-12-31T00:00:00.000Z) is after maximumDate (2023-01-01T00:00:00.000Z). Ensure minimumDate < maximumDate.',
],
[
{
value: new Date(DATE),
timeZoneName: 'Europe/Prague',
timeZoneOffsetInMinutes: 60,
},
'`timeZoneName` and `timeZoneOffsetInMinutes` cannot be specified at the same time',
],
])(
'runs the shared prop validation on %s, in both the component and the imperative api',
(props, expected) => {
expect(() => DateTimePickerAndroid.open(props)).toThrow(expected);
expect(() => RNDateTimePickerAndroid(props)).toThrow(expected);
},
);

it('reopens the picker when the design changes', () => {
const open = jest
.spyOn(DateTimePickerAndroid, 'open')
Expand Down
Loading