Run SPM-generated shell scripts under bash, not /bin/sh - #58362
Open
lazerg wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
SPM setup scripts start with
set -euo pipefail, but every one of them runs under/bin/sh. On a machine where/bin/shisn't bash (e.g. dash), that fails immediately withset: Illegal option -o pipefail, so no SwiftPM build gets past the first build phase.Two spots in
generate-spm-xcodeproj.js:shellScriptPhasehardcodesshellPath: '/bin/sh'for everyPBXShellScriptBuildPhaseit builds (Sync SPM Autolinking, Embed React Native Flavored Frameworks, plugin-contributed phases), while their bodies are bash-only. Now setsshellPath: '/bin/bash', and refreshes it on an already-injected project too.shellPathentirely — Xcode reads the shell from theActionContent's ownshellToInvokeattribute instead (default/bin/sh). Now setsshellToInvoke = "/bin/bash"on both scheme creation and when adding/refreshing the pre-action on an existing scheme.Fixes #58359
Changelog:
[IOS] [FIXED] - SwiftPM: run generated build scripts under bash instead of /bin/sh, so they don't break on a host where /bin/sh isn't bash
Test Plan:
yarn test packages/react-native/scripts/spm— 838 passed, including new cases for the refreshedshellPath/shellToInvokeon a project injected before this fix, and a scheme injected before the attribute existed.