test(rn-tester): playground repro for normalize-color partial match (#58495) - #58497
Closed
scs0209 wants to merge 1 commit into
Closed
test(rn-tester): playground repro for normalize-color partial match (#58495)#58497scs0209 wants to merge 1 commit into
scs0209 wants to merge 1 commit into
Conversation
Demonstrates issue react#58495: processColor accepts functional color strings with surrounding junk on main.
meta-cla
Bot
added
the
CLA Signed
Author
|
Closing this in favor of a single fix PR. Reproducer details are on the issue and in the unit tests on #58496. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RNTester Playground reproducer for #58495.
On
main,processColor('xxrgb(1, 2, 3)yy')(and similar junk aroundrgb/rgba) returns a non-null processed color and paints a swatch, while hex with spaces correctly staysnull.Fix PR (separate): #58496
Changelog
[INTERNAL] [CHANGED] - Add RNTester Playground repro for normalize-color partial matching
Test Plan
processColorvalues and filled swatches (bug on main).Made with Cursor