[CodeQuality] Extract shared services to de-duplicate explicit bool compare and repeated compare rules - #8506
Merged
Merged
Conversation
…ompare and repeated compare rules
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes two copy-pasted blocks flagged by the
duplicated-codedetector (surfaced at a lower token threshold).ExplicitBoolCompare rules
ArrayExplicitBoolCompareRectorandObjectExplicitBoolCompareRectorshared an identicalrefactor()preamble (short-ternary skip,BooleanNotnegation detection,Bool_cast skip, mixed/boolean native-type skip).Extracted into
ExplicitBoolConditionResolver, returning anExplicitBoolConditionvalue object (condition node + negation flag). Each rule keeps its own type-specific transform.Repeated compare to in_array rules
RepeatedAndNotEqualToNotInArrayRectorandRepeatedOrEqualToInArrayRectorshared the tail that validates the chain length, confirms all compared expressions are equal, and builds thein_array()args.Extracted into
InArrayFromRepeatedCompareFactory::createInArrayArgs(). Each rule keeps its own chain-walk (And/Or, strict-flag handling, and result wrapping).No behavior change - existing fixtures pass unchanged.