[Privatization] Remove final flag on Privatize*Rector from protected to private

[samsonasik]

Fixes rectorphp/rector#9908

On PHP 8.4, protected final is allowed, while private final is forbidden

see https://3v4l.org/gXaQt#v8.4.25 vs https://3v4l.org/lhT8c#v8.4.25

so final flag need to be removed when change protected to private, except __construct() which allowed.

[samsonasik]

@TomasVotruba ready 👍

[samsonasik]

@TomasVotruba rebased ready for merge 👍

[TomasVotruba]

Title and description needs an update

[TomasVotruba]

Can you squash it to one?
Maybe better target would be PHP 8.4 if this crashes on PHP 8.5. What fo you think?

[samsonasik]

I've updated title.

The output on 3v4l.org is since php 8.4

Before

---

After

When changed protected to private without removing final:

what do you mean for squash, the commit squashed on merge

[TomasVotruba]

Squash to 1 commit here, so its more readable. Once done.

Also, I meant a new PHP 8.4 rule that would handle this on its own. Outside privatization set compleetely.

[samsonasik]

@TomasVotruba sure, squashed 👍

[samsonasik]

On PHP < 8.4, it not support protected final yet, not sure what kind of new rule needed because that already too early error.

[TomasVotruba]

Ah, I see. So it's only invalid in here. Got it 👍

[TomasVotruba]

Thanks 👍