Skip to content

docs(datasource/apk): remove reference to renamed matcher - #45704

Open
jamietanna wants to merge 1 commit into
mainfrom
docs/apk-no-match-paths
Open

docs(datasource/apk): remove reference to renamed matcher#45704
jamietanna wants to merge 1 commit into
mainfrom
docs/apk-no-match-paths

Conversation

@jamietanna

@jamietanna jamietanna commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Changes

As this slipped past our code review, but matchPaths has been
deprecated for ~3 years, replaced by matchFileNames.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Written by Claude Opus 5 via Claude Code: code, tests and documentation.

Use of AI in replying to PR comments

Who answers review comments:

  • @jamietanna will read and reply directly.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests, but ran on a real repository, or
  • Both unit tests + ran on a real repository

The public repository: N/A

@jamietanna
jamietanna force-pushed the docs/apk-no-match-paths branch from bc4e385 to 2db16a4 Compare September 4, 2026 15:34
As this slipped past our code review, but `matchPaths` has been
deprecated for ~3 years, replaced by `matchFileNames`.

Co-authored-by: Claude Opus 5 <jamie.tanna+claude-code@mend.io>
@jamietanna
jamietanna force-pushed the docs/apk-no-match-paths branch from 2db16a4 to 644695f Compare September 4, 2026 15:35
@jamietanna jamietanna changed the title docs(datasource/apk): don't recommend matchPaths docs(datasource/apk): remove reference to renamed matcher Sep 4, 2026
@jamietanna
jamietanna marked this pull request as ready for review September 4, 2026 15:35
@jamietanna

Copy link
Copy Markdown
Contributor Author

This change can go in as-is

@jamietanna
jamietanna requested a review from a team September 4, 2026 15:35
@github-actions
github-actions Bot requested a review from viceice September 4, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants