Repository navigation
e2e: isolate Docker networks for parallel integration tests - #64
Merged
philipgough merged 2 commits intoOct 1, 2026
Conversation
Use a per-test network name derived from t.Name() with e2e.WithName, since bare e2e.New() hashes runtime.Caller(3) and collides on testing.tRunner for every test. Derive TLS/OIDC hostnames from e.Name() via getContainerName, drop fixed env name constants, and align Dex/tenant API host with the observatorium-api runnable.
Sign leaves with the parsed CA so AuthorityKeyId matches SubjectKeyId on ca.pem. Add host.docker.internal to Dex/API SANs, set tls.ServerName to the Dex Docker hostname when posting to dex/token, and fail if ca.pem does not parse into the root pool.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick two upstream commits that fix Docker network name collisions
during parallel e2e test execution.
Problem
Multiple e2e tests (e.g.
TestMetricsReadAndWrite+TestOpenAPIEndpoint)share the same Docker network name (
"metrics") and both callt.Parallel().When running concurrently,
efficientgo/e2e'se2e.New()cleans up theexisting Docker network, destroying the other test's running containers.
This causes
opacontainer startup failures,connection refusederrors,and container cleanup races.
Upstream commits
bdbc2623e84b— "e2e: isolate Docker networks for parallel integration tests"Adds
uniqueE2ENetworkName(t)function, refactors all test files to useper-test network names instead of shared constants.
85627d9b12e5— "e2e: fix Dex token TLS verification for test CA and CI"Companion fix: adds
host.docker.internalto cert SANs for per-testTLS verification.
Verification
All four make targets pass locally:
make build✅make test --always-make✅make lint --always-make✅make generate validate✅Ref: RHOBS-1792
AI-generated. Review for accuracy.
@philipgough requested from Slack