test: add unit tests for OIDC checkAuth claim extraction - #65
Merged
philipgough merged 1 commit intoOct 1, 2026
Merged
philipgough merged 1 commit into
philipgough merged 1 commit into
Conversation
Create authentication/oidc_test.go with table-driven tests covering 10 scenarios: both claims present, username-only (PR stolostron#61 behavior), group-only (PR stolostron#60 behavior), neither claim, empty username, wrong type username, group as string, group as []interface{}, no claims configured, and non-string group elements. Uses a test OIDC server with signed JWTs via go-jose/v4. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add comprehensive table-driven unit tests for the OIDC
checkAuthmethod,covering the claim extraction flexibility added in PRs #60 and #61.
What's tested
10 scenarios covering all claim permutations:
Implementation
Uses
httptest.Serverserving OIDC discovery + JWKS endpoints with RSAkey pair for signing test JWTs via
go-jose/v4. Tests exercise the fullOIDC verification pipeline — no mocks.
Verification
go test -v -race ./authentication/...✅ all passmake build✅make test --always-make✅make lint --always-make✅Ref: RHOBS-1794
AI-generated. Review for accuracy.
@philipgough requested from Slack