Repository navigation
fix: canvas filters.pinned and filters.required chips missing on load - #9990
Open
nishantmonu51 wants to merge 1 commit into
Open
nishantmonu51 wants to merge 1 commit into
nishantmonu51 wants to merge 1 commit into
Conversation
Since #9974 a canvas applies its metrics views and then its YAML config, both from the same ResolveCanvas response. When the resource list has already landed, applying the names marks the specs ready synchronously, which replays the queued URL params and builds the chips before the pinned and required filters are known. Nothing re-parsed afterwards, so the chips never showed. YAMLConfigProvider now emits an update event and ExpressionFilterManager adds the missing required and pinned chips when it fires. Chips that already exist are left untouched.
rohithreddykota
approved these changes
Oct 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResolveCanvasresponse. When the resource list has already landed, applying the names marks the specs ready synchronously, which replays the queued URL params and builds the chips before the pinned and required filters are known. Nothing re-parses afterwards, so the chips never show. Every canvas withfilters.pinnedorfilters.requiredon v0.90.3 is affected.YAMLConfigProvidernow emits anupdateevent andExpressionFilterManageradds the missing required and pinned chips when it fires (JoinerFilterManager.addRequiredAndPinnedFilters). Chips that already exist are left untouched, so spec refreshes do not churn the filter bar.mainwith the exact symptom.Steps to reproduce:
filters: pinned: [...]orrequired: [...]by navigating from the project page, so the resource list is already cached.Checklist: