fix(agentos): accept [ as a package command name - #2015
Conversation
|
This PR was not deployed automatically as @eersnington does not have access to the Railway project. In order to get automatic PR deploys, please add @eersnington to your workspace on Railway. |
| /// Remote actor SQLite rejects a statement whose bound values exceed 128 KiB. | ||
| /// The other values in a metadata chunk write are at most 272 bytes, so 64 KiB | ||
| /// leaves ample room. | ||
| const METADATA_CHUNK_SIZE: usize = 64 * 1024; |
There was a problem hiding this comment.
🔴 High · Keep existing 256 KiB metadata generations readable
Reducing this constant also changes load_metadata's format validation: it recomputes expected_chunks with 64 KiB and rejects any loaded chunk larger than 64 KiB. A database written by the previous release with, for example, a 100 KiB dump has one 100 KiB chunk, so reopening it now fails before the filesystem can mount. Keep the write chunk size at 64 KiB, but make the reader accept the legacy 256 KiB layout (or version and migrate the stored format) so persisted VMs survive the upgrade.
There was a problem hiding this comment.
i knew you'd flag this you little 💩
there is no legacy metadata. this is not even released api dawg
[(POSIXtest). The resolver allows onlyA-Z a-z 0-9 - _ . @in command names, so resolving any software list that includes coreutils fails.[is now accepted as an exact name. Other names with brackets ([x,]) and path separators are still rejected.Code:
crates/client/src/software.rsThis is part 1 of 4 in a stack: