Repository navigation
fix(effect): support stable Effect 4 - #5842
Conversation
|
🚅 Deployed to the rivet-pr-5842 environment in rivet-frontend
|
|
Review: fix(effect): support stable Effect 4 I read the full diff except Things to double check
Code quality
Docs and tests
No security concerns. This is a mechanical upgrade that looks consistent. The main risk is the API renames, so a green CI run is the thing to wait for. |
| "@vitest/coverage-v8": "^5.0.3", | ||
| "publint": "^0.3.21", | ||
| "rivetkit": "workspace:*", | ||
| "typescript": "^5.9.2", |
There was a problem hiding this comment.
🟠 Medium · Vitest 5 raises the Node floor beyond the declared runtime support
vitest@5.0.3 declares node: ^22.12.0 || ^24.0.0 || >=26.0.0, while this workspace still declares Node >=20 and the rivetkit package declares >=22.0.0. As a result, supported Node 20 and Node 22.0–22.11 environments now install an unsupported test runner for this package and the three updated examples. Since stable @effect/vitest requires Vitest 5, update the relevant engines.node declarations/toolchain floor to >=22.12.0 (and add matching engines to the examples) in the same migration.
@rivetkit/effectand its examples to stable Effect 4 and compatible Vitest 5.